Skip to content

Commit

Permalink
fix: flat config would cause an error with non-svelte files (#711)
Browse files Browse the repository at this point in the history
  • Loading branch information
ota-meshi committed Mar 18, 2024
1 parent 76eeea3 commit aaba61f
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 7 deletions.
5 changes: 5 additions & 0 deletions .changeset/soft-suns-brush.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-svelte": patch
---

fix: flat config would cause an error with non-svelte files
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@
"@types/prismjs": "^1.26.3",
"@types/semver": "^7.5.8",
"@types/stylus": "^0.48.42",
"@typescript-eslint/eslint-plugin": "^7.1.1",
"@typescript-eslint/parser": "^7.1.1",
"@typescript-eslint/eslint-plugin": "^7.3.0",
"@typescript-eslint/parser": "^7.3.0",
"@typescript/vfs": "^1.5.0",
"acorn": "^8.11.3",
"assert": "^2.1.0",
Expand Down
6 changes: 4 additions & 2 deletions src/configs/flat/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@
import type { ESLint } from 'eslint';
export default [
{
files: ['*.svelte', '**/*.svelte'],
plugins: {
get svelte(): ESLint.Plugin {
// eslint-disable-next-line @typescript-eslint/no-require-imports -- ignore
return require('../../index');
}
},
}
},
{
files: ['*.svelte', '**/*.svelte'],
languageOptions: {
// eslint-disable-next-line @typescript-eslint/no-require-imports -- ignore
parser: require('svelte-eslint-parser')
Expand Down
4 changes: 2 additions & 2 deletions src/meta.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// IMPORTANT!
// This file has been automatically generated,
// in order to update its content execute "pnpm run update"
export const name = 'eslint-plugin-svelte' as const;
export const version = '2.36.0-next.11' as const;
export const name = 'eslint-plugin-svelte';
export const version = '2.36.0-next.11';
12 changes: 12 additions & 0 deletions tests/src/configs/recommended.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,17 @@ describe('`all` config', () => {
}
]
);

const resultWithJs = await linter.lintText(';', { filePath: 'test.js' });
const messagesWithJs = resultWithJs[0].messages;

assert.deepStrictEqual(
messagesWithJs.map((m) => ({
ruleId: m.ruleId,
line: m.line,
message: m.message
})),
[]
);
});
});
4 changes: 3 additions & 1 deletion tools/update-rulesets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,15 @@ const baseContent = `/*
import type { ESLint } from 'eslint';
export default [
{
files: ["*.svelte", "**/*.svelte"],
plugins: {
get svelte(): ESLint.Plugin {
// eslint-disable-next-line @typescript-eslint/no-require-imports -- ignore
return require("../../index")
}
},
},
{
files: ["*.svelte", "**/*.svelte"],
languageOptions: {
// eslint-disable-next-line @typescript-eslint/no-require-imports -- ignore
parser: require('svelte-eslint-parser'),
Expand Down

0 comments on commit aaba61f

Please sign in to comment.