Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: warn about the typescript parser being a singleton #423

Merged
merged 1 commit into from
Mar 28, 2023
Merged

docs: warn about the typescript parser being a singleton #423

merged 1 commit into from
Mar 28, 2023

Conversation

JP-Ellis
Copy link
Contributor

The TypeScript parser uses a singleton internally, which means that repeated parserOptions will be ignored, using only the first one. This can lead to unexpected behaviour if there are multiple possible configurations.

This closes #422.

Ref: #422

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023 •
edited

⚠️ No Changeset found

Latest commit: 04804ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 28, 2023 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JP-Ellis JP-Ellis changed the title docs(eslint-plugin): warn about the typescript parser being a singleton docs: warn about the typescript parser being a singleton Mar 28, 2023
ota-meshi
ota-meshi reviewed Mar 28, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@JP-Ellis
docs: warn about the typescript parser being a singleton
04804ee 
The TypeScript parser uses a singleton internally, which means that
repeated `parserOptions` will be ignored, using only the first one. This
can lead to unexpected behaviour if there are multiple possible
configurations.

This closes #422.

Ref: #422
Signed-off-by: JP-Ellis <josh@jpellis.me>
ota-meshi
ota-meshi approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@ota-meshi ota-meshi merged commit de1fd3d into sveltejs:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESLint Flat Configuration
2 participants
@JP-Ellis @ota-meshi