Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tests to follow latest Svelte 5 #751

Merged
merged 1 commit into from
May 7, 2024
Merged

chore: fix tests to follow latest Svelte 5 #751

merged 1 commit into from
May 7, 2024

Conversation

baseballyama
Copy link
Member

@baseballyama baseballyama commented May 6, 2024

I just added Node 22 but CI does not pass in #750

sveltejs/svelte#11327 changes warning messages, so I mainly copied exist tests and optimized for Svelte 5.

Copy link

changeset-bot bot commented May 6, 2024

⚠️ No Changeset found

Latest commit: 5027c8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@baseballyama
Copy link
Member Author

So, I think sveltejs/svelte#11327 changes messages, so messages between Svelte 4 and Svelte 5 is not same anymore.
We need to add a feature that should be possible to declare a test specifically for Svelte 4 or Svelte 5.

@baseballyama baseballyama changed the title chore: Fix CI errors chore: allows tests to be declared exclusively for Svelte 4 or Svelte 5 May 6, 2024
@baseballyama
Copy link
Member Author

baseballyama commented May 6, 2024

We need to wait to solve this issue.

  • tests/fixtures/rules/valid-compile/valid/svelte-ignore07-svelte5-input.svelte

sveltejs/svelte#11482

@baseballyama baseballyama marked this pull request as draft May 6, 2024 06:08
@baseballyama baseballyama changed the title chore: allows tests to be declared exclusively for Svelte 4 or Svelte 5 chore: fix tests to follow latest Svelte 5 May 6, 2024
@baseballyama baseballyama force-pushed the chore/fix-ci branch 3 times, most recently from 4383b3a to 8155033 Compare May 6, 2024 09:24
@@ -128,7 +128,8 @@ const config = [
},
rules: {
'n/file-extension-in-import': 'off',
'n/no-unsupported-features/es-syntax': 'off'
'n/no-unsupported-features/es-syntax': 'off',
'n/no-unsupported-features/es-builtins': 'off'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to disable n/no-unsupported-features/es-builtins for window.btoa.

<a href="#" on:click={(evt) => onClickMessage(evt, msg)} class="message-link"
>[{msg.line}:{msg.column}]</a
>:
<button on:click={(evt) => onClickMessage(evt, msg)} class="message-link">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved the warning.

@baseballyama baseballyama marked this pull request as ready for review May 6, 2024 09:27
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 60e784e into main May 7, 2024
12 checks passed
@ota-meshi ota-meshi deleted the chore/fix-ci branch May 7, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants