Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make server assets accessible during vite preview #10511

Merged
merged 2 commits into from Aug 9, 2023

Conversation

eltigerchino
Copy link
Member

fixes #9961

This moves the server assets copying to client assets closer to the vite build process instead of as part of the adapter process. This ensures server assets are always included in .svelte-kit/output/client so that vite preview serves them correctly.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

🦋 Changeset detected

Latest commit: 74a2183

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghostdevv
Copy link
Member

ghostdevv commented Aug 9, 2023

The history of this code is super weird it seems to have been changed/reverted multiple times - looks like ben has been editing this part the most so requesting a review from him

@benmccann benmccann merged commit 0595e92 into master Aug 9, 2023
14 checks passed
@benmccann benmccann deleted the fix-vite-preview-server-assets branch August 9, 2023 22:44
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Elia872 pushed a commit to Elia872/kit that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assets not output when imported in +page.server.ts
3 participants