Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load trailing slash option from server even when there's no load function #10531

Closed
wants to merge 6 commits into from

Conversation

GingerAdonis
Copy link
Contributor

@GingerAdonis GingerAdonis commented Aug 11, 2023

While creating a test for #10475 I've noticed that the existing trailing-slash-server tests weren't actually using the server trailingSlash option. I've changed that which caused the tests to fail. The analyser skipped over this option when there's no load function. This PR includes both the changed test, and the fix for this test.

There might be a better approach, but this is what I came up with after digging in the code for 2 days.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

🦋 Changeset detected

Latest commit: 76a0f93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Thank you! Since those PRs are closely related, could you incorporate the changes here into the other PR? You can create multiple changesets for one PR.

On the change itself: It's a bit unfortunate that we'd have to do a load just for this. An alternative might be to check for this edge case and add that config to a client load function instead. I haven't dug into how many things there would need to be changed, so if it's too much I'd be ok with the current solution.

@GingerAdonis
Copy link
Contributor Author

Thank you! Since those PRs are closely related, could you incorporate the changes here into the other PR? You can create multiple changesets for one PR.

Will do!

On the change itself: It's a bit unfortunate that we'd have to do a load just for this. An alternative might be to check for this edge case and add that config to a client load function instead. I haven't dug into how many things there would need to be changed, so if it's too much I'd be ok with the current solution.

It's indeed unfortunate. I have only limited knowledge of the Kit codebase, but as far as I can tell that would be quite a lot of work. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants