New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: process globs in pkg.workspaces
#10625
Conversation
🦋 Changeset detectedLatest commit: ec6de03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/kit/postinstall.js
Outdated
@@ -18,7 +17,11 @@ try { | |||
const packages = Array.isArray(pkg.workspaces) ? pkg.workspaces : pkg.workspaces.packages; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const packages = Array.isArray(pkg.workspaces) ? pkg.workspaces : pkg.workspaces.packages; | |
// it can be a glob pattern https://docs.npmjs.com/cli/v9/configuring-npm/package-json#workspaces | |
const patterns = Array.isArray(pkg.workspaces) ? pkg.workspaces : pkg.workspaces.packages; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about instead changing line 16 & 17 to
// Find all NPM and Yarn workspace glob patterns
// https://classic.yarnpkg.com/blog/2018/02/15/nohoist/
// https://docs.npmjs.com/cli/v9/configuring-npm/package-json#workspaces
const patterns = Array.isArray(pkg.workspaces) ? pkg.workspaces : pkg.workspaces.packages;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed that comment, and also renamed "directories" -> "workspaces" as I think that makes more sense here too
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
pkg.workspaces
Reverts #10174 to fix #10610 - I also added a check for if the directory is actually a directory as I noticed that was breaking when triaging #10610
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.