Skip to content

fix: ensure File is pollyfilled for Node 18.11+ #10948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

eltigerchino
Copy link
Member

fixes #10946

Quick fix that ensures File is always polyfilled rather than just pre Node 18.11.0. The global was only added in Node 20, while buffer.File was only added in Node 18.13.0
https://nodejs.org/dist/latest-v20.x/docs/api/globals.html#class-file

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Sorry, something went wrong.

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2023

🦋 Changeset detected

Latest commit: 45f12a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title add File to post node 18.11 polyfills fix: ensure File is always pollyfilled Oct 28, 2023
@eltigerchino eltigerchino changed the title fix: ensure File is always pollyfilled fix: ensure File is always pollyfilled for Node 18.11+ Oct 28, 2023
@eltigerchino eltigerchino changed the title fix: ensure File is always pollyfilled for Node 18.11+ fix: ensure File is pollyfilled for Node 18.11+ Oct 28, 2023
@dummdidumm
Copy link
Member

Mhhhhhm does this interfer with undici now again, as in "different versions are used and undici breaks", because File could come from our undici version and the other stuff could come from the built-in undici version?

@gtm-nayan
Copy link
Contributor

Could but looks like File at least has some leeway by virtue of being based on Blob so undici has some quacks-like-a-duck logic to prevent such errors. Also on 18.13+ both undici and our polyfill try to use the File from buffer first so newer versions should not have any mismatches

@eltigerchino eltigerchino merged commit f706ac5 into master Oct 28, 2023
@eltigerchino eltigerchino deleted the fix-node-file-polyfill branch October 28, 2023 14:20
@github-actions github-actions bot mentioned this pull request Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: File is not defined on 1.27.1
3 participants