Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for nodejs20.x to vercel adapter #11067

Merged
merged 2 commits into from Nov 17, 2023
Merged

Conversation

dummdidumm
Copy link
Member

fixes #11063
Also relaxed the checks in the adapter a bit, so we don't need to adjust it as often - Vercel will fail the build itself with a descriptive error if the value is wrong

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

fixes #11063
Also relaxed the checks in the adapter a bit, so we don't need to adjust it as often - Vercel will fail the build itself with a descriptive error if the value is wrong
Copy link

changeset-bot bot commented Nov 17, 2023

🦋 Changeset detected

Latest commit: 6197771

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-vercel Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 3757d3f into master Nov 17, 2023
14 checks passed
@dummdidumm dummdidumm deleted the vercel-node-20 branch November 17, 2023 15:03
@github-actions github-actions bot mentioned this pull request Nov 17, 2023
@dummdidumm dummdidumm added the pkg:adapter-vercel Pertaining to the Vercel adapter label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:adapter-vercel Pertaining to the Vercel adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for node20.x for @sveltejs/adapter-vercel
2 participants