Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: solve issues with basic auth username:password in URLs #11179

Merged
merged 8 commits into from
Jan 9, 2024
Merged

fix: solve issues with basic auth username:password in URLs #11179

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce2420d
fix: `history.replaceState` with absolute path instead of href (svelt…
LorenzoLeonardini Dec 2, 2023
27e8059
fix: detect basic auth credentials in URL and remove them
LorenzoLeonardini Dec 3, 2023
b7d20c8
fix: detect basic auth credentials with `document.URL`
LorenzoLeonardini Dec 11, 2023
9081a06
Merge remote-tracking branch 'upstream/main'
LorenzoLeonardini Jan 9, 2024
5a614b1
fix: remove location.href from replaceState
LorenzoLeonardini Jan 9, 2024
bc86711
fix: change basic auth url credentials detection
LorenzoLeonardini Jan 9, 2024
833e442
Update packages/kit/src/runtime/client/client.js
Rich-Harris Jan 9, 2024
c21b675
Update .changeset/long-adults-arrive.md
Rich-Harris Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/long-adults-arrive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: solve issues with basic auth username:password in URLs (#10522)
Rich-Harris marked this conversation as resolved.
Show resolved Hide resolved
11 changes: 9 additions & 2 deletions packages/kit/src/runtime/client/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,14 @@ export async function start(_app, _target, hydrate) {
);
}

// detect basic auth credentials in the current URL
// https://github.com/sveltejs/kit/pull/11179
// if so, refresh the page without credentials
if (document.URL !== location.href) {
// eslint-disable-next-line no-self-assign
location.href = location.href;
}

app = _app;
routes = parse(_app);
container = __SVELTEKIT_EMBEDDED__ ? _target : document.documentElement;
Expand Down Expand Up @@ -251,8 +259,7 @@ export async function start(_app, _target, hydrate) {
[HISTORY_INDEX]: current_history_index,
[NAVIGATION_INDEX]: current_navigation_index
},
'',
location.href
''
);
}

Expand Down