Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve relative cookie paths before storing #11253

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Conversation

Rich-Harris
Copy link
Member

per #9299 (comment), this resolve relative (same-domain) cookie paths before storing them locally. It doesn't affect the behaviour of cookies in the browser, but means that if you do this...

cookies.set('a', 'b', { path: '.' });
console.log(cookies.get('a'));

...it will correctly log b instead of trying to retrieve the cookie from headers. Super niche bug that AFAIK no-one has hit, but now that we're explicitly recommending that people use relative paths, it makes sense to fix it.

Tested locally, didn't add one to this PR because it's covered in version-2.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Sorry, something went wrong.

Copy link

changeset-bot bot commented Dec 10, 2023

🦋 Changeset detected

Latest commit: 1629d85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ugh
fix

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant