Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust fail method and ActionFailure type #11260

Merged
merged 3 commits into from
Dec 11, 2023
Merged

fix: Adjust fail method and ActionFailure type #11260

merged 3 commits into from
Dec 11, 2023

Commits on Dec 11, 2023

  1. fix: Adjust fail method and ActionFailure type 

    - add ActionFailure interface and use that publicly instead of the class. Prevents the false impression that you could do "instanceof" on the return type, fixes #10361
- add uniqueSymbol to ActionFailure instance so we can distinguish it from a regular return with the same shape
- fix setup to actually run test/types
    @dummdidumm
    dummdidumm committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    bf0282b View commit details
    Browse the repository at this point in the history

  2. test

    @dummdidumm
    dummdidumm committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    3f42f60 View commit details
    Browse the repository at this point in the history

  3. regenerate types

    @Rich-Harris
    Rich-Harris committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    3ee8b79 View commit details
    Browse the repository at this point in the history