-
-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: resolveRoute
function
#11261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resolveRoute
function
#11261
Conversation
🦋 Changeset detectedLatest commit: 14e7ff1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
We could do this - though it will probably mean that people end up migrating it manually as opposed to via the migration tool and I'm not sure if we have a preference there |
I trust deprecation warnings more than I trust automated migrations. I definitely don't think the existence of a migration tool should prevent us from providing useful feedback — there will be plenty of people who want to address deprecation warnings (possibly over a period of time) who aren't ready to bump majors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess in this case it'd be hard to automigrate anyway since this one includes the base. I forgot for a moment that we're doing more than moving the package and renaming the function.
I didn't check if this is in the migration guide already. If it's not, we might want to include that update as part of this PR
this is the deprecation PR. the migration instructions will be part of the removal PR |
#10282. after this is merged into
master
, andmaster
is merged intoversion-2
, we can open another PR that removesresolvePath
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.