Skip to content

feat: resolveRoute function #11261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 11, 2023
Merged

feat: resolveRoute function #11261

merged 4 commits into from
Dec 11, 2023

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Dec 11, 2023

#10282. after this is merged into master, and master is merged into version-2, we can open another PR that removes resolvePath

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Sorry, something went wrong.

Copy link

changeset-bot bot commented Dec 11, 2023

🦋 Changeset detected

Latest commit: 14e7ff1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

We could do this - though it will probably mean that people end up migrating it manually as opposed to via the migration tool and I'm not sure if we have a preference there

@Rich-Harris
Copy link
Member Author

I trust deprecation warnings more than I trust automated migrations. I definitely don't think the existence of a migration tool should prevent us from providing useful feedback — there will be plenty of people who want to address deprecation warnings (possibly over a period of time) who aren't ready to bump majors

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in this case it'd be hard to automigrate anyway since this one includes the base. I forgot for a moment that we're doing more than moving the package and renaming the function.

I didn't check if this is in the migration guide already. If it's not, we might want to include that update as part of this PR

@Rich-Harris
Copy link
Member Author

If it's not, we might want to include that update as part of this PR

this is the deprecation PR. the migration instructions will be part of the removal PR

@Rich-Harris Rich-Harris merged commit d7eb990 into master Dec 11, 2023
@Rich-Harris Rich-Harris deleted the deprecate-resolve-path branch December 11, 2023 21:11
@github-actions github-actions bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants