-
-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: prevent endless SPA 404 loop #11354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9936f5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Perhaps we could add a test that would fail without this change? I think we've got a couple test apps that use a fallback page |
I ended up creating a new test app because many of the other ones rely on ssr being enabled. This test specifically requires SSR to be disabled in the root layout so that the error page isn't server-side rendered. |
thank you! |
Including several fixes for a serious 404 bug in SvelteKit. See: <sveltejs/kit#11354>
fixes #11227
This PR reverts the changes in #11025 that reloaded the page when fetching data failed. Now, it just avoids parsing the response body if it's not JSON and returns the same HttpError with a simplified error message based on the status (we have been doing the same in the server).
No test unless we want to setup a new test suite without a root error load function to reproduce the issue.quick reproduction: https://github.com/eltigerchino/sveltekit-bug-11227
pnpm i && pnpm dev
/example
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.