Skip to content

#11421 part two #11540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 8, 2024
Merged

#11421 part two #11540

merged 8 commits into from
Jan 8, 2024

Conversation

Rich-Harris
Copy link
Member

#11421, but I moved the test (couldn't push to the original PR, confusingly/annoyingly)

PatrickG and others added 7 commits December 20, 2023 19:19

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Copy link

changeset-bot bot commented Jan 8, 2024

🦋 Changeset detected

Latest commit: 8bb740e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

couldn't push to the original PR, confusingly/annoyingly

@PatrickG usually when that happens it's because the PR submitter unchecked "allow edits by maintainers" - just a heads up for next time that it makes the process a bit smoother if you can leave that checked

@Rich-Harris Rich-Harris merged commit 129a9a3 into main Jan 8, 2024
@Rich-Harris Rich-Harris deleted the gh-11355 branch January 8, 2024 20:17
@github-actions github-actions bot mentioned this pull request Jan 8, 2024
@PatrickG
Copy link
Member

PatrickG commented Jan 9, 2024

couldn't push to the original PR, confusingly/annoyingly

@PatrickG usually when that happens it's because the PR submitter unchecked "allow edits by maintainers" - just a heads up for next time that it makes the process a bit smoother if you can leave that checked

I thought I checked it, when I created that PR. But apparently I didn't.
Sorry

Or is it checked by default? Then I've unchecked it, because I thought it is unchecked.

@dummdidumm
Copy link
Member

AFAIK it has to do with making a PR from the main branch of the fork, which is always protected. So if you're making a branch on your fork it should work as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants