Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't stash away original history methods so other libs can monkeypatch it #11657

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix: don't stash away original history methods so other libs can monkeypatch it #11657

merged 2 commits into from
Jan 17, 2024

Commits on Jan 17, 2024

  1. fix: don't stash away original history methods so other libs can mo… 

    …nkeypatch it

Some other libraries might hook into `history.replaceState/pushState` to do additional work. This no longer works since the introduction of shallow routing because we're stashing away the original history methods. This PR adjusts the DEV time check logic so that this is no longer necessary.
Related to vercel/analytics#121
    @dummdidumm
    dummdidumm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    0c18402 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
    @Rich-Harris @benmccann
    Rich-Harris and benmccann committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3bf2146 View commit details
    Browse the repository at this point in the history