Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect build.target config supplied by user #11688

Merged
merged 1 commit into from Jan 19, 2024
Merged

fix: respect build.target config supplied by user #11688

merged 1 commit into from Jan 19, 2024

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Jan 19, 2024

closes #11658

please review the question in #11658 (comment) while deciding whether this is safe

Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: 2c98af9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me now that we're no longer using TLA in framework code. I'm unsure whether we should continue to enforce node18.13 or if we should do initial_config.build?.target ?? 'node18.13'

@benmccann
Copy link
Member Author

I'm unsure whether we should continue to enforce node18.13 or if we should do initial_config.build?.target ?? 'node18.13'

I don't think we need to touch it. It's the same in SvelteKit 2 and SvelteKit 1 and no one's ever had an issue with it, so I'd rather not mess with it and risk breaking things. People may be setting target without checking if they're in the SSR build and if we start taking the user's value we could break those projects

@benmccann benmccann merged commit 36dc54a into main Jan 19, 2024
13 checks passed
@benmccann benmccann deleted the target branch January 19, 2024 17:51
@github-actions github-actions bot mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SvelteKit 2 does not transform logical assignments with es2015 target
2 participants