fix: exclude service worker from tsconfig again #11727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a0c33b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
changed the title
benmccann
reviewed
Jan 24, 2024
benmccann
reviewed
Jan 25, 2024
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
trueadm
approved these changes
Mar 6, 2024
eltigerchino
approved these changes
Mar 6, 2024
Merged
gurpreetatwal
added a commit
to gurpreetatwal/sveltekit
that referenced
this pull request
May 7, 2024
The [docs](https://kit.svelte.dev/docs/service-workers) state that the service worker can be located at `src/service-worker.js` or as an `index.js` file within the `src/service-worker` directory. Without this fix users who place the file within the directory run into Typescript errors like [sveltejs#11721](https://github.com/sveltejs/kit/issues/117210) Follow up to [sveltejs#11727](sveltejs#11727)
gurpreetatwal
added a commit
to gurpreetatwal/sveltekit
that referenced
this pull request
May 7, 2024
The [docs](https://kit.svelte.dev/docs/service-workers) state that the service worker can be located at `src/service-worker.js` or as an `index.js` file within the `src/service-worker` directory. Without this fix users who place the file within the directory run into Typescript errors like [sveltejs#11721](https://github.com/sveltejs/kit/issues/117210) Follow up to [sveltejs#11727](sveltejs#11727)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing this was an accidental breaking change as part of #10994, strictly speaking. The new solution isn't ideal but very few people will use
$env/static/publicso it's probably fine. The one drawback is thatambient.d.tsis now semi-public (I guess it always was in some way).fixes #11721
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits