Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip /@fs prefix correctly on Windows when invoking read() in dev mode #11728

Merged
merged 1 commit into from Jan 25, 2024

Conversation

dummdidumm
Copy link
Member

Windows absolute paths look like /@fs/C:/.. - when stripping the fs prefix, we need to remove the additional slash after the fs


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 24, 2024

🦋 Changeset detected

Latest commit: 36dc773

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

Can we mention in the title and in the changes etc that this is for read()? (I'm assuming it doesn't also affect anything else.) And is this only for dev mode?

…in dev mode

Windows absolute paths look like `/@fs/C:/..` - when stripping the fs prefix, we need to remove the additional slash after the fs
@dummdidumm dummdidumm changed the title fix: strip /@fs prefix correctly on Windows fix: strip /@fs prefix correctly on Windows when invoking read() in dev mode Jan 24, 2024
@dummdidumm dummdidumm merged commit 507311b into main Jan 25, 2024
13 checks passed
@dummdidumm dummdidumm deleted the fix-fs-strip branch January 25, 2024 09:04
@github-actions github-actions bot mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants