Fixed discrepancies in page store between server and client #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehrencrona
commented
Nov 3, 2020
| }); | ||
| } | ||
|
|
||
| search.slice(1).split('&').filter(Boolean).forEach(searchParam => { |
There was a problem hiding this comment.
there was a teeny tiny bug in here: the query string ?a=b& would become translated to {a: 'b', '': ''}
as for the rest of the function i refactored it because i think this is more readable and also shorter
|
Looks like this one has a merge conflict |
ehrencrona
force-pushed
the
same-page-context-client-and-server
branch
from
eb13ad8
to
f700856
Compare
|
rebased |
You can probably do that now that a couple of the other PRs have been checked in |
ehrencrona
force-pushed
the
same-page-context-client-and-server
branch
from
f700856
to
4676fcb
Compare
|
I moved Would be good to get this merged now; there will quickly be new conflicts in the types. |
dummdidumm
approved these changes
Nov 17, 2020
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host was
nullon the server side using dev server. The query was aURLSearchParamson the server and a map on the client.(This should be safeguarded by types; I'll add that once my other PRs regarding types are merged)
Fixes #118 (except for
errorbeingnullvsundefined; that's fixed by #108)