-
-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: configure Vite config optimizeDeps.entries
option
#12182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+236
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d61d3f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
optimizeDeps.entries
optimizeDeps.entries
option
dominikg
reviewed
May 2, 2024
dominikg
reviewed
May 2, 2024
dominikg
reviewed
May 3, 2024
packages/kit/test/apps/basics/test/cross-platform/client.test.js
Outdated
Show resolved
Hide resolved
dominikg
approved these changes
May 3, 2024
great to see the added test working 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11793
We need to specify
optimizeDeps.entries
for the Vite config to scan for dependencies that should be optimised because we have setrollupOptions.build.input
and that overrides Vite's default scanning behaviour. This prevents the excessive Vite dependency optimisation and reloading on page navigation during development when it discovers dependencies used by the page.Note that this PR merges the
optimizeDeps.entries
specified by the user's Vite configuration instead of overriding it. We considered just adding these to the Vite user config so it's more visible but there's no way to retrieve the dynamic path of the Kit routes folder and hook file names which are configurable insvelte.config.js
.Additional context from the maintainer's Discord chat.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits