Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: determine local Svelte version more reliably #12350

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

Rich-Harris
Copy link
Member

It's currently impossible to develop a Svelte 5 project with a linked SvelteKit installation, because the sync script wrongly believes it's dealing with Svelte 4 (which is a dev dependency inside SvelteKit). This fixes it.

I added a changeset because it's a change, but it doesn't actually require a release since the problem it solves only arises when you're working with the repo directly.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Sorry, something went wrong.

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 0f9b25e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -128,7 +128,7 @@ const warning_preprocessor = {
* rather than relative to this package
* @param {string} dependency
*/
async function resolve_peer_dependency(dependency) {
function resolve_peer_dependency(dependency) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this out into a util and reuse it in the other file or not worth it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i was just being lazy

fix
gah
@Rich-Harris Rich-Harris merged commit 835ebf6 into main Jun 14, 2024
11 of 13 checks passed
@Rich-Harris Rich-Harris deleted the facilitate-svelte-5-dev branch June 14, 2024 22:53
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants