-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: determine local Svelte version more reliably #12350
Conversation
🦋 Changeset detectedLatest commit: 0f9b25e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -128,7 +128,7 @@ const warning_preprocessor = { | |||
* rather than relative to this package | |||
* @param {string} dependency | |||
*/ | |||
async function resolve_peer_dependency(dependency) { | |||
function resolve_peer_dependency(dependency) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move this out into a util and reuse it in the other file or not worth it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i was just being lazy
It's currently impossible to develop a Svelte 5 project with a linked SvelteKit installation, because the
sync
script wrongly believes it's dealing with Svelte 4 (which is a dev dependency inside SvelteKit). This fixes it.I added a changeset because it's a change, but it doesn't actually require a release since the problem it solves only arises when you're working with the repo directly.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits