fix: warn on invalid cookie name characters #12806
Merged
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7756acc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eltigerchino
changed the title
eltigerchino
changed the title
eltigerchino
commented
Oct 14, 2024
benmccann
reviewed
Oct 14, 2024
…to warn-cookie-name
dummdidumm
reviewed
Oct 14, 2024
| @@ -113,6 +116,14 @@ export function get_cookies(request, url, trailing_slash) { | |||
| * @param {import('./page/types.js').Cookie['options']} options | |||
| */ | |||
| set(name, value, options) { | |||
| // TODO: remove this check in 3.0 | |||
| const illegal_characters = name.match(INVALID_COOKIE_CHARACTER_REGEX); | |||
| if (illegal_characters) { | |||
There was a problem hiding this comment.
Should we only warn once per cookie name? Else you might get flooded depending on how often you use them
There was a problem hiding this comment.
I dunno. We really don't want folks to miss this or their apps will break. If it's just one line in a thousand that their app logs then they might overlook it. I don't think this is terrible. Most people won't be affected, but we really do want folks to see it when they are
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12799
Adds a warning at dev time of which characters in the cookie name are invalid according to the RFC
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits