Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] accept PUBLIC as prefix for environment variables #2355

Closed
wants to merge 2 commits into from
Closed

[feat] accept PUBLIC as prefix for environment variables #2355

wants to merge 2 commits into from

Conversation

benmccann
Copy link
Member

Closes #2308

@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2021 •
edited

🦋 Changeset detected

Latest commit: 6ef28e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ignatiusmb
ignatiusmb approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@ignatiusmb ignatiusmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least PUBLIC_ makes it clear that it's public.

@dummdidumm
Copy link
Member

I think the changelog should make it more clear that this is a breaking change and how to fix it.

@antony
Copy link
Member

antony commented Sep 3, 2021

It's not breaking in that we also still support VITE_. However it is breaking in that if I had an env var called PUBLIC_DATABASE_PASSWORD which was previously a private env var, it is now exposed. It's a super edge case but it could happen.

It doesn't feel like a patch version.

@dummdidumm
Copy link
Member

Everything's a patch version in next versions right now

@antony
Copy link
Member

antony commented Sep 3, 2021

Oh hah, yes it is :)

dreitzner
dreitzner approved these changes Sep 4, 2021
View reviewed changes
Copy link
Contributor

@dreitzner dreitzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and can be extended with exposing it through the settings at a later point.

@Rich-Harris Rich-Harris mentioned this pull request Sep 6, 2021
Closed
@Rich-Harris
Copy link
Member

Commented on #2308 (comment) — tl;dr I feel like this maybe makes things more complicated?

@benmccann benmccann closed this Sep 14, 2021
@benmccann benmccann deleted the env-var-prefix branch September 14, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm left review comments

@ignatiusmb ignatiusmb ignatiusmb approved these changes

@dreitzner dreitzner dreitzner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change env var prefix
6 participants
@benmccann @dummdidumm @antony @Rich-Harris @ignatiusmb @dreitzner