Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] simple dot exports for adapters #2387

Closed
wants to merge 2 commits into from

Conversation

ignatiusmb
Copy link
Member

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2021

🦋 Changeset detected

Latest commit: d187129

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-static Patch
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

I don't know that this is proper and that the old version wasn't. Is there something in the Node docs showing what we have in master is wrong? I think this is more likely due to a Vite bug. Anyway, they have a PR to revert the log message (vitejs/vite#4873), so let's see what happens there before changing anything on our side

@ignatiusmb ignatiusmb changed the title [fix] proper dot exports for adapters [fix] simple dot exports for adapters Sep 8, 2021
@ignatiusmb
Copy link
Member Author

Sorry, "proper" was not the right choice of words. The current is one in master is also correct and can even support multiple types of import styles. Though, I found this silences the warning on the adapters side and we won't be using the extra features it gives anyway since we're only using/encouraging ES modules import style.

@benmccann
Copy link
Member

Thanks for taking a look at quieting the output. They've checked in the change to silence the message in Vite, so let's just go with that

@benmccann benmccann closed this Sep 8, 2021
@Conduitry Conduitry deleted the i2384/missing-dot-export branch January 11, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants