New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve ci e2e setup to include multiple browsers, optimize trace capturing #5058
Merged
Rich-Harris
merged 20 commits into
sveltejs:master
from
dominikg:ci/playwright-improvements
Jul 8, 2022
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
499d2e7
test: improve ci e2e setup to include multiple browsers, optimize tra…
dominikg 520bb16
fix: action syntax
dominikg cd51c5a
chore: fix formatting
dominikg 36ae83a
fix: wait for kit started on page.goBack and page.reload, remove cust…
dominikg 9f05f21
fix: improve firefox test results, add browser to results archive name
dominikg a01f231
chore: fix format
dominikg 035a4e7
fix: use downloaded chromium for adapter static test too
dominikg 1f95bb3
perf: tell vite watcher to ignore playwright output in test projects
dominikg 7637784
ci: archive all test results including retries
dominikg 4a82b3e
chore: add comment for crude wait in test
dominikg dc1af20
fix: add playwright back to root package.json so that `pnpm playwrigh…
dominikg 6752b44
merge master
benmccann 144aee5
merge master
Rich-Harris 3c33266
merge master
Rich-Harris ea7b60d
fix firefox bug, i think
Rich-Harris 2bf6934
try to diagnose failure
Rich-Harris ea2f866
cross fingers, sacrifice goat
Rich-Harris 61a154e
perchance this pleaseth the webkit gods
Rich-Harris de831ee
appease firefox, which i think scrolls to the focused element or some…
Rich-Harris 3218239
Create breezy-hairs-greet.md
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@sveltejs/kit": patch | ||
--- | ||
|
||
reset selection in setTimeout after navigating, to ensure correct behaviour in Firefox |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comments here confuse me a bit. back called page.goBack internally as well, so if it is about the behavior of back(), that wasn't working.
Or is it just refering to the fact that the first one goes to an SPA page and the second one has to do load because it's not part of the SPA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, they both should be similar, there's no concept of native vs client-side back. Plus,
back()
is usingwindow.navigated
which is not there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may have been a holdover. At some point we switched whether we updated the URL before/after updating the page contents. I think the point was to wait until the page contents were updated and then we'd have the
window.navigated
property, but maybe that was removed during the switch. Rich might be able to confirm or you could look up the PR that made the switch to confirm (can't remember what the title was, but I'm pretty sure it was authored by Rich)