Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow symlinked assets #5089

Merged
merged 7 commits into from May 30, 2022
Merged

allow symlinked assets #5089

merged 7 commits into from May 30, 2022

Conversation

gaarf
Copy link
Contributor

@gaarf gaarf commented May 26, 2022

This might fix #4709

my monorepo setup uses symlinked static assets, and it worked great until #5047 !
I believe that check for the casing was too restrictive, so I went ahead and made this PR addressing the issue. There's a test included in the basics app. The issue really only applies to dev, since the build copies symlink contents transparently.

Thanks in advance for the review 🙏

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2022

🦋 Changeset detected

Latest commit: 90a0204

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

prettier

skip test on windows

Revert "skip test on windows"

This reverts commit f8e55e6.

skip test completely
@gaarf
Copy link
Contributor Author

gaarf commented May 27, 2022

@anarchodin @mrkishi @Rich-Harris please have a look 🪟 🔗 ⬆️

@Rich-Harris
Copy link
Member

thank you! the correct fix looks a bit different — we can't just check the end of the path, because that won't work if the symlink source and target have different names. instead we're just checking that file exists in fs.readdirSync(path.dirname(file)), which is only true if the case is correct (and then doing that recursively)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerenderer don't follow symbolic link in assets folder
2 participants