Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Use vite preview port in templates for playwright config #5433

Merged
merged 9 commits into from Jul 8, 2022
Merged

[fix] Use vite preview port in templates for playwright config #5433

merged 9 commits into from Jul 8, 2022

Conversation

philip-weber
Copy link
Contributor

Closes #5429 which was introduced with #5392.

I have changed the web server port from 3000 to 4173 in the playwright.config.js templates to be in line with the preview server ports from vite.

I am not totally sure if the changes to the tests are good enough. But if the vite ports will change in the future the tests should be failing.

I am also not quite sure if my selections for the changeset are correct.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2022

⚠️ No Changeset found

Latest commit: 7487461

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few suggestions

.changeset/lemon-elephants-chew.md Outdated Show resolved Hide resolved
packages/kit/test/apps/basics/test/test.js Outdated Show resolved Hide resolved
packages/kit/test/apps/basics/test/test.js Outdated Show resolved Hide resolved
packages/kit/test/apps/basics/test/test.js Outdated Show resolved Hide resolved
packages/kit/test/apps/basics/test/test.js Outdated Show resolved Hide resolved
philip-weber and others added 4 commits July 8, 2022 21:37
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
@philip-weber
Copy link
Contributor Author

Thank you for your suggestions.

@Rich-Harris
Copy link
Member

thanks!

@philip-weber philip-weber deleted the align-playwright-port-with-vite-preview-server branch July 8, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playwright times out due to bad default port setting
2 participants