Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove chokidar as dependency of kit #5996

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

Conduitry
Copy link
Member

Now that svelte-kit package is no longer a part of core SvelteKit, it no longer needs chokidar as a dependency.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2022

🦋 Changeset detected

Latest commit: 535c9d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Conduitry
Copy link
Member Author

The test failures look to be caused by flakiness on GitHub's side. The issue isn't in the action runner, but rather that the github.com URL that the build is trying to download the sharp binaries from is 500ing.

@Rich-Harris
Copy link
Member

Yeah, that happens periodically. Is there an alternative to vite-imagetools that doesn't use sharp? Would be great to use a JS-only dependency if a suitable one exists

@Rich-Harris Rich-Harris merged commit 9191023 into sveltejs:master Aug 17, 2022
@Conduitry Conduitry deleted the kit-rm-chokidar branch August 17, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants