Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vite-plugin-svelte to 1.3.1 #7760

Merged
merged 2 commits into from Nov 23, 2022
Merged

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Nov 22, 2022

Enables prebundling by default and allows it to be disabled. Also adds performance logging printed by default

Closes #2612

@dominikg
Copy link
Member

test error locally:

@sveltejs/kit:test: [WebServer] [vite-plugin-svelte] EISDIR: illegal operation on a directory, read
@sveltejs/kit:test: [WebServer] error during build:
@sveltejs/kit:test: Error: EISDIR: illegal operation on a directory, read
@sveltejs/kit:test:     at Object.readSync (node:fs:748:3)
@sveltejs/kit:test:     at tryReadSync (node:fs:448:20)
@sveltejs/kit:test:     at readFileSync (node:fs:494:19)
@sveltejs/kit:test:     at VitePluginSvelteStats._aggregateStatsResult (file:///home/dominikg/develop/sveltejs/kit/node_modules/.pnpm/@sveltejs+vite-plugin-svelte@1.3.0_svelte@3.53.1+vite@3.2.3/node_modules/@sveltejs/vite-plugin-svelte/dist/index.js:1211:33)
@sveltejs/kit:test:     at async VitePluginSvelteStats._finish (file:///home/dominikg/develop/sveltejs/kit/node_modules/.pnpm/@sveltejs+vite-plugin-svelte@1.3.0_svelte@3.53.1+vite@3.2.3/node_modules/@sveltejs/vite-plugin-svelte/dist/index.js:1187:7)
@sveltejs/kit:test:     at async Object.finish (file:///home/dominikg/develop/sveltejs/kit/node_modules/.pnpm/@sveltejs+vite-plugin-svelte@1.3.0_svelte@3.53.1+vite@3.2.3/node_modules/@sveltejs/vite-plugin-svelte/dist/index.js:1172:9)
@sveltejs/kit:test:     at async Promise.all (index 0)
@sveltejs/kit:test:     at async VitePluginSvelteStats.finishAll (file:///home/dominikg/develop/sveltejs/kit/node_modules/.pnpm/@sveltejs+vite-plugin-svelte@1.3.0_svelte@3.53.1+vite@3.2.3/node_modules/@sveltejs/vite-plugin-svelte/dist/index.js:1179:5)
@sveltejs/kit:test:     at async Object.buildEnd (file:///home/dominikg/develop/sveltejs/kit/node_modules/.pnpm/@sveltejs+vite-plugin-svelte@1.3.0_svelte@3.53.1+vite@3.2.3/node_modules/@sveltejs/vite-plugin-svelte/dist/index.js:2185:9)
@sveltejs/kit:test:     at async Promise.all (index 0)
@sveltejs/kit:test: Error: Process from config.webServer was not able to start. Exit code: 1

this looks like the new stats code failing, wonder why though, file reads only happen when vitefu returned a package.json path. cc @bluwy

@dominikg
Copy link
Member

most likely caused by a directory named package.json in the test routes

@dummdidumm dummdidumm marked this pull request as draft November 22, 2022 18:46
@changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2022

🦋 Changeset detected

Latest commit: b532141

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dominikg
Copy link
Member

the windows fail is lovely: https://github.com/sveltejs/kit/actions/runs/3533939103/jobs/5930221484#step:8:229

@sveltejs/kit:test: Error: Process from config.webServer was not able to start. Exit code: 0
@sveltejs/kit:test: 
@sveltejs/kit:test: 
@sveltejs/kit:test: 
@sveltejs/kit:test: 
@sveltejs/kit:test:   7 skipped
@sveltejs/kit:test:   1 error was not a part of any test, see above for details

so the exit code is 0, and no error logged. any clue what happened here? @benmccann is this the flakiness you mentioned?

@dominikg
Copy link
Member

restarted windows and linux+firefox, the windows test result archive was 45bytes and empty too wth

@benmccann benmccann changed the title Upgrade vite-plugin-svelte to 1.3.0 Upgrade vite-plugin-svelte to 1.3.1 Nov 23, 2022
@benmccann benmccann merged commit 6cbde19 into sveltejs:master Nov 23, 2022
@benmccann benmccann deleted the vps-1.3 branch November 23, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prebundling of libraries with Svelte components
2 participants