Skip to content

remove format option from generateManifest(...) #7820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

closes #7798. I haven't yet checked community adapters to make sure no-one is using this

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Sorry, something went wrong.

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2022

🦋 Changeset detected

Latest commit: ca3c4c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

double-checked all the community adapters listed on sveltesociety.dev, seems we're in the clear

@Rich-Harris Rich-Harris merged commit 3663fe6 into master Nov 27, 2022
@Rich-Harris Rich-Harris deleted the gh-7798 branch November 27, 2022 15:27
@benmccann
Copy link
Member

this seems to be causing a lint failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove format: 'cjs' option from builder.generateManifest(...)
2 participants