-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[fix]Continuous optionals should not throw conflict error #7939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: c84b40e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Could you add a changeset and add a test in the index.spec.js
file next to the changed file?
okay, done. |
thanks for the test, however for this it's sufficient to create a unit test - you would create another unit test similar to the existing one in |
thank you, I'll try it. |
Someone is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
fix issue 7925
folder structure [[a]]/[[b]]/+page will throw routes conflict error
the error from the function
prevent_conflicts
here:
will generate permutations [ '//', '/<>/', '//<>', '/<>/<>' ]
but actually, it' impossible match route /empty/[[b]] . so '//<*>' should be remove from result.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0