Skip to content

[fix] throw error when using enhance on GET forms #7948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Dec 5, 2022

closes #7896
closes #7972

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Sorry, something went wrong.

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022

🦋 Changeset detected

Latest commit: 281f81e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

I agree with not including the helpful error message in prod builds - but I was wondering whether we might want to do something here in that case, even if it means just returning early so that the action is a no-op? Completely skipping the check is probably fine if that's what other people want to do, but I wanted to at least bring it up.

@dummdidumm
Copy link
Member Author

I'm not sure the extra bytes are worth it - if this made it to production, the noop won't help much, especially if you maybe want this to run with JS only anyway.

@Rich-Harris Rich-Harris merged commit 7d1c0a3 into master Dec 8, 2022
@Rich-Harris Rich-Harris deleted the throw-form-get branch December 8, 2022 21:06
This was referenced Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progressively enhanced form calls an action with GET use:enhance breaks forms that are not method=POST
3 participants