Skip to content

add type declaration for vitePreprocess reexport #8053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

gtm-nayan
Copy link
Contributor

@gtm-nayan gtm-nayan commented Dec 10, 2022

aside: Using 'declare module' for these exports kind of feels like a hack to me, unless it's needed for the docs we should maybe be using "exports.types" alongside the js files listed in package.json but out of scope for this PR.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Sorry, something went wrong.

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2022

🦋 Changeset detected

Latest commit: d4afa1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Using 'declare module' for these exports kind of feels like a hack to me

Agree with that sentiment, I can't remember if there's a reason we're doing in this way rather than generating .d.ts files in prepublishOnly. (Though writing them by hand is useful for one very specific reason — we can rename a function like invalid to fail in a way that will cause a red squiggly when you import the old function but that will also allow us to export a function with the old name that errors at runtime with a helpful error.)

@Rich-Harris Rich-Harris merged commit 1264ae5 into master Dec 10, 2022
@Rich-Harris Rich-Harris deleted the vitePreprocess-decl branch December 10, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants