Skip to content

Set correct $page.status when using enhance and result is of type 'error' #8073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 11, 2022

Conversation

PatrickG
Copy link
Member

Fixes #8072

I wanted to create a +error.svelte in test/apps/basic/src/routes/actions/enhance for this test, but somehow it is not mounted in the "js"-test. I also tried to put it in test/apps/basic/src/routes/actions, that also didn't work.
Furthermore, I've tried to debug with playwright debug, but couldn't find any reason why it does not work.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Sorry, something went wrong.

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2022

🦋 Changeset detected

Latest commit: 37e03f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 11, 2022

@PatrickG is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! (type check error is unrelated)

@dummdidumm dummdidumm merged commit 96751b0 into sveltejs:master Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$page.status 500 when using use:enahnce
3 participants