Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update request type definitions to make platform possibly undefined #8232

Merged
merged 6 commits into from
Jan 5, 2023
Merged

Update request type definitions to make platform possibly undefined #8232

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aeb9d24
fallback platform to empty object
chrskerr Dec 20, 2022
5ac3152
Update .changeset/shy-monkeys-raise.md
dummdidumm Dec 20, 2022
fd4871b
mark platform type as possibly undefined instead
chrskerr Dec 27, 2022
a5ab784
Update packages/kit/types/index.d.ts
Rich-Harris Jan 5, 2023
8ef902b
Update .changeset/shy-monkeys-raise.md
Rich-Harris Jan 5, 2023
b3f172c
Update packages/kit/types/index.d.ts
Rich-Harris Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shy-monkeys-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Update typings of `event.platform` to be possibly undefined
2 changes: 1 addition & 1 deletion packages/kit/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,7 +865,7 @@ export interface RequestEvent<
/**
* Additional data made available through the adapter.
*/
platform: Readonly<App.Platform>;
platform: Readonly<App.Platform> | void;
Rich-Harris marked this conversation as resolved.
Show resolved Hide resolved
/**
* The original request object
*/
Expand Down