Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove buggy cookie path detection #9298

Merged
merged 4 commits into from Mar 6, 2023
Merged

remove buggy cookie path detection #9298

merged 4 commits into from Mar 6, 2023

Conversation

Rich-Harris
Copy link
Member

closes #9130

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is not with how we set the incoming cookie, because through cookie.set we can track the path correctly. I think in the case of tests the problem is that we basically track the existing cookie paths in a singleton, which likely spans all Playwright workers. I'm not sure how others run into this, but given the comments in the issue it seems to happen, so I'm ok with removing some these checks.

(I would also remove the comment in line 126/127 because it references the now removed warning from the delete branch)

packages/kit/src/runtime/server/cookie.js Show resolved Hide resolved
packages/kit/src/runtime/server/cookie.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie with name 'fail-type' was not found at path '...'
2 participants