Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pause on debugger for full page reloads in dev #9305

Merged
merged 1 commit into from Mar 8, 2023
Merged

Conversation

Rich-Harris
Copy link
Member

closes #9284

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but not merging yet, to see if we can batch something else into a minor release that's a feature.

In general I was wondering if things like this would be better served through some kind of dev time overlay. I don't know how much Vite let's us customize its overlay, and if it's possible to ping back to the dev server here. Maybe it's also our own custom dev time info overlay similar to how NextJS has them. Anyways, these are just nebolous thoughts I thought may fit here.

@Rich-Harris
Copy link
Member Author

Agree. Astro is another example closer to home - they override the vite overlay. There's lots of room for improvement around errors generally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give a warning when the root load function failed.
3 participants