Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
onNavigate
lifecycle function, to enable view transitions #9605Add
onNavigate
lifecycle function, to enable view transitions #9605Changes from 21 commits
a91064e
fb3f63b
a993dcb
46a24bf
e0b6849
79ae0c3
44bd6f8
0b52c89
937675e
70b9825
8a1f528
54b1e46
6b1b4c8
fa16886
02dc70f
f417004
a6aacc0
e96195b
eff8b4a
0e1b593
c68d625
7f868b8
c7c8aa8
5ba3015
4ebf02b
d0e3a74
fa6bc93
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels a bit loose to just return strings here. Should we declare a set of
const
s that are reused? And should it just be "navigation was aborted" or a more techincal/stable-looking thing likeNAV_ABORTED
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying the error message part of the public API and the user needs to check which error message is present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is getting thrown when updating query params via
goto()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should open an issue with a reproduction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed by 1.24.1 (tried to update ?) #10666
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated and no more error, thanks
This file was deleted.