Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #9605, I realised that the
update(...)
function inclient.js
is really quite badly designed. It's used for both navigations and invalidations, but it spends so much time deciding which of those things it's dealing with that it really shouldn't be a single function.In fact, in the invalidation case almost none of the logic is actually used. We can move that stuff into the
invalidate
function, and inline the entirety ofupdate
intonavigate
. This means less indirection, and easier-to-follow code.This change will make it easier to add a
complete
promise to theNavigation
interface.No tests or changeset necessary.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.