Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor navigate #9698

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Refactor navigate #9698

merged 3 commits into from
Apr 18, 2023

Conversation

Rich-Harris
Copy link
Member

While working on #9605, I realised that the update(...) function in client.js is really quite badly designed. It's used for both navigations and invalidations, but it spends so much time deciding which of those things it's dealing with that it really shouldn't be a single function.

In fact, in the invalidation case almost none of the logic is actually used. We can move that stuff into the invalidate function, and inline the entirety of update into navigate. This means less indirection, and easier-to-follow code.

This change will make it easier to add a complete promise to the Navigation interface.

No tests or changeset necessary.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2023

⚠️ No Changeset found

Latest commit: 8db99e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rich-Harris Rich-Harris merged commit 58fca91 into master Apr 18, 2023
10 checks passed
@Rich-Harris Rich-Harris deleted the refactor-navigate branch April 18, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants