Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add privatePrefix for private environment variables #9996

Merged
merged 12 commits into from Jun 28, 2023

Conversation

tcc-sejohnson
Copy link
Contributor

@tcc-sejohnson tcc-sejohnson commented May 20, 2023

Closes #9776.

Adds a new config option, config.kit.env.privatePrefix, for setting a private prefix on environment variables. This defaults to ''.

To prevent super-weird and unexpected behaviors, the logic is:

  • private: does not begin with public prefix, does begin with private prefix
  • public: does begin with public prefix, does not begin with private prefix

This has the side benefit of not allowing the two prefixes to be the same.

Note: Had to create env.js utils file so that the utils could be imported into server/index -- putting them pretty much anywhere else ended up causing a transitive dependency on some node package somewhere that wasn't compatible with Node 16.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented May 20, 2023

🦋 Changeset detected

Latest commit: 5a78adc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

just a heads up, there's a merge conflict on this one

@tcc-sejohnson
Copy link
Contributor Author

Weird; thanks

packages/kit/src/exports/public.d.ts Outdated Show resolved Hide resolved
@dummdidumm dummdidumm merged commit 47d8048 into master Jun 28, 2023
14 checks passed
@dummdidumm dummdidumm deleted the elliott/9776-add-private-prefix branch June 28, 2023 14:04
@github-actions github-actions bot mentioned this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefix for private env variables
3 participants