(fix) extract name in destructuring with default (#1605)

#1604
sveltejs · Aug 28, 2022 · 5f0d769 · 5f0d769
1 parent 645ce2d
commit 5f0d769
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 0 deletions.
diff --git a/packages/svelte2tsx/src/svelte2tsx/utils/tsAst.ts b/packages/svelte2tsx/src/svelte2tsx/utils/tsAst.ts
@@ -100,6 +100,8 @@ export function extractIdentifiers(
                 extractIdentifiers(element, identifiers);
             }
         });
+    } else if (ts.isBinaryExpression(node)) {
+        extractIdentifiers(node.left, identifiers);
     }
 
     return identifiers;

diff --git a/packages/svelte2tsx/test/svelte2tsx/samples/reactive-declare-destructuring/expected.tsx b/packages/svelte2tsx/test/svelte2tsx/samples/reactive-declare-destructuring/expected.tsx
@@ -6,6 +6,7 @@ let  { b: d } = __sveltets_1_invalidate(() => ({ b: '' }));
 let  { c: { length } } = __sveltets_1_invalidate(() => ({ c: '' }));
 let  { ...e } = __sveltets_1_invalidate(() => ({ f: ''}));
 let  { f } = __sveltets_1_invalidate(() => ({ f: ''}));
+let  { b: g = 1} = __sveltets_1_invalidate(() => ({ b: 1 }));
 ;
 () => (<></>);
 return { props: {}, slots: {}, getters: {}, events: {} }}

diff --git a/packages/svelte2tsx/test/svelte2tsx/samples/reactive-declare-destructuring/expectedv2.ts b/packages/svelte2tsx/test/svelte2tsx/samples/reactive-declare-destructuring/expectedv2.ts
@@ -6,6 +6,7 @@ let  { b: d } = __sveltets_1_invalidate(() => ({ b: '' }));
 let  { c: { length } } = __sveltets_1_invalidate(() => ({ c: '' }));
 let  { ...e } = __sveltets_1_invalidate(() => ({ f: ''}));
 let  { f } = __sveltets_1_invalidate(() => ({ f: ''}));
+let  { b: g = 1} = __sveltets_1_invalidate(() => ({ b: 1 }));
 ;
 async () => {};
 return { props: {}, slots: {}, getters: {}, events: {} }}

diff --git a/packages/svelte2tsx/test/svelte2tsx/samples/reactive-declare-destructuring/input.svelte b/packages/svelte2tsx/test/svelte2tsx/samples/reactive-declare-destructuring/input.svelte
@@ -4,4 +4,5 @@ $: ({ b: d } = { b: '' });
 $: ({ c: { length } } = { c: '' });
 $: ({ ...e } = { f: ''});
 $: ( { f } = { f: ''} );
+$: ({ b: g = 1} = { b: 1 });
 </script>