Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getCompletionEntryDetails crash #1629

Merged
merged 2 commits into from Sep 12, 2022
Merged

fix getCompletionEntryDetails crash #1629

merged 2 commits into from Sep 12, 2022

Conversation

zardoy
Copy link
Contributor

@zardoy zardoy commented Sep 12, 2022 •
edited by dummdidumm

By the type data can be undefined, unfortunately due to limited time, I can't provide exact str of to get undefined in data, most probably some another plugin causing it. Anyway, casting possibly undefined value to any usually a bad idea. Thank you.

#1630

@zardoy
Copy link
Contributor Author

zardoy commented Sep 12, 2022

str is extremely simple: "svelte.enable-ts-plugin": true

@dummdidumm dummdidumm merged commit 4397110 into sveltejs:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zardoy @dummdidumm