Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) use let for #each block #1636

Merged
merged 1 commit into from Sep 15, 2022
Merged

(fix) use let for #each block #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/language-server/test/plugins/typescript/TypescriptPlugin.test.ts
View file
Open in desktop
Expand Up @@ -203,7 +203,7 @@ function test(useNewTransformation: boolean) {
},
{
name: 'foo',
kind: 14,
kind: 13,
location: {
uri: getUri('documentsymbols.svelte'),
range: {
Expand Down
4 changes: 2 additions & 2 deletions packages/svelte2tsx/src/htmlxtojsx_v2/nodes/EachBlock.ts
View file
Open in desktop
Expand Up @@ -34,13 +34,13 @@ export function handleEach(str: MagicString, eachBlock: BaseNode): void {
transforms = [
`{ const $$_each = __sveltets_2_ensureArray(${containsComma ? '(' : ''}`,
[eachBlock.expression.start, eachBlock.expression.end],
`${containsComma ? ')' : ''}); for(const `,
`${containsComma ? ')' : ''}); for(let `,
[eachBlock.context.start, eachBlock.context.end],
' of $$_each){'
];
} else {
transforms = [
'for(const ',
'for(let ',
[eachBlock.context.start, eachBlock.context.end],
` of __sveltets_2_ensureArray(${containsComma ? '(' : ''}`,
[eachBlock.expression.start, eachBlock.expression.end],
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/htmlx2jsx/samples/blocks-without-whitespace-inbetween/expectedv2.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/htmlx2jsx/samples/each-block-basic-sequence/expectedv2.js
View file
Open in desktop
@@ -1,3 +1,3 @@
for(const item of __sveltets_2_ensureArray((true, items))){
for(let item of __sveltets_2_ensureArray((true, items))){
{ svelteHTML.createElement("div", {});item; }
}
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/htmlx2jsx/samples/each-block-basic/expectedv2.js
View file
Open in desktop
@@ -1,3 +1,3 @@
for(const item of __sveltets_2_ensureArray(items)){
for(let item of __sveltets_2_ensureArray(items)){
{ svelteHTML.createElement("div", {});item; }
}
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/htmlx2jsx/samples/each-block-index/expectedv2.js
View file
Open in desktop
@@ -1,3 +1,3 @@
for(const item of __sveltets_2_ensureArray(items)){let i = 1;
for(let item of __sveltets_2_ensureArray(items)){let i = 1;
{ svelteHTML.createElement("div", {});item;i; }
}
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/htmlx2jsx/samples/each-block-key-else/expectedv2.js
View file
Open in desktop
@@ -1,4 +1,4 @@
for(const item of __sveltets_2_ensureArray(items)){let i = 1;item.id;
for(let item of __sveltets_2_ensureArray(items)){let i = 1;item.id;
{ svelteHTML.createElement("div", {});item;i; }
}
{ svelteHTML.createElement("div", {}); }
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/htmlx2jsx/samples/each-block-key/expectedv2.js
View file
Open in desktop
@@ -1,3 +1,3 @@
for(const item of __sveltets_2_ensureArray(items)){let i = 1;item.id;
for(let item of __sveltets_2_ensureArray(items)){let i = 1;item.id;
{ svelteHTML.createElement("div", {});item;i; }
}
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/htmlx2jsx/samples/each-block-nullish-coalescing/expectedv2.js
View file
Open in desktop
@@ -1,3 +1,3 @@
for(const item of __sveltets_2_ensureArray(items ?? [])){
for(let item of __sveltets_2_ensureArray(items ?? [])){
{ svelteHTML.createElement("div", {});item; }
}
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/htmlx2jsx/samples/each-block-optional-chaining/expectedv2.js
View file
Open in desktop
@@ -1,3 +1,3 @@
for(const item of __sveltets_2_ensureArray(someObject?.items)){
for(let item of __sveltets_2_ensureArray(someObject?.items)){
{ svelteHTML.createElement("div", {});item; }
}
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/htmlx2jsx/samples/editing-animation/expectedv2.js
View file
Open in desktop
@@ -1,3 +1,3 @@
for(const item of __sveltets_2_ensureArray(list)){item;
for(let item of __sveltets_2_ensureArray(list)){item;
{ svelteHTML.createElement("li", { });__sveltets_2_ensureAnimation(flip(svelteHTML.mapElementTag('li'),__sveltets_2_AnimationMove,(opt?.)));item; }
}
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/htmlx2jsx/samples/editing-const/expectedv2.js
View file
Open in desktop
@@ -1,3 +1,3 @@
for(const str of __sveltets_2_ensureArray([''])){
for(let str of __sveltets_2_ensureArray([''])){
const lower = str.;
}
14 changes: 7 additions & 7 deletions packages/svelte2tsx/test/htmlx2jsx/samples/if-nested-each-block-shadowed/expectedv2.js
View file
Open in desktop
@@ -1,13 +1,13 @@
if(hello){
for(const hello of __sveltets_2_ensureArray(items)){let i = 1;hello.id;
for(let hello of __sveltets_2_ensureArray(items)){let i = 1;hello.id;
{ svelteHTML.createElement("div", {});hello;i; }
if(hello){
for(const hello of __sveltets_2_ensureArray(items)){
for(let hello of __sveltets_2_ensureArray(items)){
if(hello){
hello;
}
}
for(const foo of __sveltets_2_ensureArray(items)){
for(let foo of __sveltets_2_ensureArray(items)){
const hello = foo;
if(hello){
hello;
Expand All @@ -20,25 +20,25 @@ if(hello){
}

if(hi && bye){
for(const bye of __sveltets_2_ensureArray(items)){
for(let bye of __sveltets_2_ensureArray(items)){
{ svelteHTML.createElement("div", {});bye; }
}
if(bye){
bye;
}

} else if (cool){
for(const item of __sveltets_2_ensureArray(items)){let cool = 1;
for(let item of __sveltets_2_ensureArray(items)){let cool = 1;
{ svelteHTML.createElement("div", {});item;cool; }
}
}else{
for(const hello of __sveltets_2_ensureArray(items)){
for(let hello of __sveltets_2_ensureArray(items)){
{ svelteHTML.createElement("div", {});hello; }
}
}
}

for(const hello of __sveltets_2_ensureArray(items)){let i = 1;
for(let hello of __sveltets_2_ensureArray(items)){let i = 1;
if(hello && i && bye){
hello; i; bye;
} else if (hello && i && bye){
Expand Down
8 changes: 4 additions & 4 deletions packages/svelte2tsx/test/htmlx2jsx/samples/if-nested-each-block/expectedv2.js
View file
Open in desktop
@@ -1,19 +1,19 @@
if(hello){
for(const item of __sveltets_2_ensureArray(items)){let i = 1;item.id;
for(let item of __sveltets_2_ensureArray(items)){let i = 1;item.id;
{ svelteHTML.createElement("div", {});item;i; }
}
if(hi && bye){
for(const item of __sveltets_2_ensureArray(items)){
for(let item of __sveltets_2_ensureArray(items)){
{ svelteHTML.createElement("div", {});item; }
}
{ svelteHTML.createElement("p", {}); }

} else if (cool){
for(const item of __sveltets_2_ensureArray(items)){let i = 1;
for(let item of __sveltets_2_ensureArray(items)){let i = 1;
{ svelteHTML.createElement("div", {});item;i; }
}
}else{
for(const item of __sveltets_2_ensureArray(items)){
for(let item of __sveltets_2_ensureArray(items)){
{ svelteHTML.createElement("div", {});item; }
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/htmlx2jsx/samples/nested-if-else-if-and-each-block/expectedv2.js
View file
Open in desktop
@@ -1,5 +1,5 @@
if(true){
if(true){} else if (true){}
}else{
for(const _ of __sveltets_2_ensureArray([])){}
for(let _ of __sveltets_2_ensureArray([])){}
}
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/svelte2tsx/samples/circle-drawer-example/expectedv2.ts
View file
Open in desktop
Expand Up @@ -70,7 +70,7 @@ async () => {
}

{ svelteHTML.createElement("svg", { "on:click":handleClick,});
for(const circle of __sveltets_2_ensureArray(circles)){
for(let circle of __sveltets_2_ensureArray(circles)){
{ svelteHTML.createElement("circle", { "cx":circle.cx,"cy":circle.cy,"r":circle.r,"on:click":event => select(circle, event),"on:contextmenu":() => {
adjusting = !adjusting;
if (adjusting) selected = circle;
Expand Down
4 changes: 2 additions & 2 deletions packages/svelte2tsx/test/svelte2tsx/samples/component-slot-inside-each/expectedv2.ts
View file
Open in desktop
@@ -1,10 +1,10 @@
///<reference types="svelte" />
;function render() {
/*Ωignore_startΩ*/;const __sveltets_createSlot = __sveltets_2_createCreateSlot();/*Ωignore_endΩ*/
async () => { for(const item of __sveltets_2_ensureArray(items)){
async () => { for(let item of __sveltets_2_ensureArray(items)){
{ __sveltets_createSlot("default", { "a":item,}); }
}
for(const { a } of __sveltets_2_ensureArray(items2)){
for(let { a } of __sveltets_2_ensureArray(items2)){
{ __sveltets_createSlot("second", { a,}); }
}};
return { props: {}, slots: {'default': {a:__sveltets_1_unwrapArr(items)}, 'second': {a:(({ a }) => a)(__sveltets_1_unwrapArr(items2))}}, getters: {}, events: {} }}
Expand Down
4 changes: 2 additions & 2 deletions packages/svelte2tsx/test/svelte2tsx/samples/component-slot-nest-scope/expectedv2.ts
View file
Open in desktop
@@ -1,8 +1,8 @@
///<reference types="svelte" />
;function render() {
/*Ωignore_startΩ*/;const __sveltets_createSlot = __sveltets_2_createCreateSlot();/*Ωignore_endΩ*/
async () => { for(const item of __sveltets_2_ensureArray(items)){
for(const { a } of __sveltets_2_ensureArray(item)){
async () => { for(let item of __sveltets_2_ensureArray(items)){
for(let { a } of __sveltets_2_ensureArray(item)){
{ __sveltets_createSlot("default", {a,}); }
}
{ __sveltets_createSlot("second", { a,}); }
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/svelte2tsx/samples/component-slot-object-key/expectedv2.ts
View file
Open in desktop
@@ -1,7 +1,7 @@
///<reference types="svelte" />
;function render() {
/*Ωignore_startΩ*/;const __sveltets_createSlot = __sveltets_2_createCreateSlot();/*Ωignore_endΩ*/
async () => { for(const item of __sveltets_2_ensureArray(items)){
async () => { for(let item of __sveltets_2_ensureArray(items)){
{ __sveltets_createSlot("default", { "a":item,"b":{ item },"c":{ item: 'abc' }.item,"d":{ item: item },"e":$item,"f":$item,...g,...item,}); }
}};
return { props: {}, slots: {'default': {a:__sveltets_1_unwrapArr(items), b:{ item:__sveltets_1_unwrapArr(items) }, c:{ item: 'abc' }.item, d:{ item: __sveltets_1_unwrapArr(items) }, e:$item, f:$item, ...g, ...__sveltets_1_unwrapArr(items)}}, getters: {}, events: {} }}
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/svelte2tsx/samples/component-slot-var-shadowing/expectedv2.ts
View file
Open in desktop
@@ -1,7 +1,7 @@
///<reference types="svelte" />
;function render() {
/*Ωignore_startΩ*/;const __sveltets_createSlot = __sveltets_2_createCreateSlot();/*Ωignore_endΩ*/
async () => { { const $$_each = __sveltets_2_ensureArray(items); for(const items of $$_each){
async () => { { const $$_each = __sveltets_2_ensureArray(items); for(let items of $$_each){
{ __sveltets_createSlot("default", { "a":items,}); }
}}};
return { props: {}, slots: {'default': {a:__sveltets_1_unwrapArr(items)}}, getters: {}, events: {} }}
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/svelte2tsx/samples/const-tag-each-destructure/expectedv2.ts
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@
;
async () => {

for(const { width, height } of __sveltets_2_ensureArray(boxes)){
for(let { width, height } of __sveltets_2_ensureArray(boxes)){
const {area, volume} = calculate(width, height, constant);
const perimeter = (width + height) * constant;
const [_width, _height, sum] = [width * constant, height, width * constant + height];
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte2tsx/test/svelte2tsx/samples/const-tag-each/expectedv2.ts
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@
;
async () => {

for(const box of __sveltets_2_ensureArray(boxes)){
for(let box of __sveltets_2_ensureArray(boxes)){
const {area, volume} = calculate(box.width, box.height, constant);
const perimeter = (box.width + box.height) * constant;
const [width, height, sum] = [box.width * constant, box.height, box.width * constant + box.height];
Expand Down