Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) skip inferring type for event forwarded from svelte:self #1693

Merged
merged 1 commit into from Oct 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 9 additions & 7 deletions packages/svelte2tsx/src/svelte2tsx/nodes/event-handler.ts
Expand Up @@ -10,13 +10,15 @@ export class EventHandler {
// pass-through/ bubble
if (!node.expression) {
if (parent.type === 'InlineComponent') {
this.handleEventHandlerBubble(parent, eventName);
} else {
this.bubbledEvents.set(
eventName,
getEventDefExpressionForNonCompoent(eventName, parent)
);
if (parent.name !== 'svelte:self') {
this.handleEventHandlerBubble(parent, eventName);
}
return;
}
this.bubbledEvents.set(
eventName,
getEventDefExpressionForNonComponent(eventName, parent)
);
}
}

Expand Down Expand Up @@ -58,7 +60,7 @@ export class EventHandler {
}
}

function getEventDefExpressionForNonCompoent(eventName: string, ele: Node) {
function getEventDefExpressionForNonComponent(eventName: string, ele: Node) {
switch (ele.type) {
case 'Element':
return `__sveltets_1_mapElementEvent('${eventName}')`;
Expand Down
@@ -0,0 +1,23 @@
///<reference types="svelte" />
<></>;
import { createEventDispatcher } from "svelte";
function render() {



let a = [''];
const dispatch = createEventDispatcher<{
foo: string
}>();
;
() => (<>

{__sveltets_1_each(a, (item) => <>
<svelteself ></svelteself>
</>)}</>);
return { props: {}, slots: {}, getters: {}, events: {...__sveltets_1_toEventTypings<{
foo: string
}>()} }}

export default class Input__SvelteComponent_ extends __sveltets_1_createSvelte2TsxComponent(__sveltets_1_partial(__sveltets_1_with_any_event(render()))) {
}
@@ -0,0 +1,23 @@
///<reference types="svelte" />
;
import { createEventDispatcher } from "svelte";
function render() {



let a = [''];
const dispatch = createEventDispatcher<{
foo: string
}>();
;
async () => {

for(let item of __sveltets_2_ensureArray(a)){
{ const $$_svelteself0 = __sveltets_2_createComponentAny({ });$$_svelteself0.$on("foo", () => {}); }
}};
return { props: {}, slots: {}, getters: {}, events: {...__sveltets_1_toEventTypings<{
foo: string
}>()} }}

export default class Input__SvelteComponent_ extends __sveltets_1_createSvelte2TsxComponent(__sveltets_1_partial(__sveltets_1_with_any_event(render()))) {
}
@@ -0,0 +1,12 @@
<script lang="ts">
import { createEventDispatcher } from "svelte";

let a = [''];
const dispatch = createEventDispatcher<{
foo: string
}>();
</script>

{#each a as item}
<svelte:self on:foo></svelte:self>
{/each}