Add option to ignore warnings #198
Conversation
|
We had discussed about the warning a while ago and agreed to remove it altogether, so another option here is not needed. vite-plugin-svelte had already done so at sveltejs/vite-plugin-svelte#272. This is also in my todo list for rollup-plugin-svelte but never got to it. Feel free to tackle it if you like. Besides removing the warning, we also need to manually read the |
|
Ok. I'm not super confident in the inner workings of this, but I've made a few changes now to port the recursive check from vite-plugin-svelte. Perhaps that will ease the workload for you? |
README.md
Outdated
| // Ignore warnings regarding packages not exporting their package.json file | ||
| // by adding the package name to this array. | ||
| ignoreExportsWarn: []; | ||
|
|
index.d.ts
Outdated
|
|
||
| /** Ignore warnings regarding packages not exporting their package.json file | ||
| * by adding the package name to this array. | ||
| */ | ||
| ignoreExportsWarn: string[]; |
index.js
Outdated
| } catch (err) { | ||
| if (err.code === 'MODULE_NOT_FOUND') return {pkg: null, dir}; | ||
| if (err.code === 'ERR_PACKAGE_PATH_NOT_EXPORTED') { | ||
| dir = path.dirname(relative.resolve(name)); |
There was a problem hiding this comment.
| dir = path.dirname(relative.resolve(name)); | |
| dir = path.dirname(relative.resolve(name, path.dirname(importer)); |
I think we need to specify the importer too. Perhaps we can abstract this as a function since it's used in the try block too.
|
this looks ok for me, would be great to validate that it works as expected on windows. The logic of resolving the "svelte" field in package.json isn't really bundler dependant so i wonder if this was something that could/should live in it's own package to be reusable? (out of scope for this PR) |
This PR adds an option in rollup.config.js to ignore warnings about package.json not being exported. See discussion in #181.