Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

separate <Layout> from <Error> in generate_app( ) #1250

Closed
wants to merge 1 commit into from

Conversation

thebells1111
Copy link

_error.svelte will now be able to be styled independently of _layout.svelte to allow for unique error pages. This is in response to the comment by @intrikate in PR #948: _error.svelte should not inherit the common layout by default.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@Conduitry
Copy link
Member

Thanks - but while we do want to have a way for pages to know whether they are an error page, I don't think we want to do it this way - which would be a breaking change in any case.

@Conduitry Conduitry closed this Jun 3, 2020
@ArekBartnik
Copy link
Contributor

@Conduitry it would be a breaking change but easily fixable (move some components from _layout to _error)

I think the reasoning should be this - if _layout encapsulates correct pages, _error should do the same for error pages.
Now there's an inconsistent pattern.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants