This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Preload js assets - fixes #408 #712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed the webpack build issue. |
|
What's the status on this? I'm getting dinged by google for not having preload. |
|
@rwwagner90 @matt3224 if it important for you try to install sapper from my branch. Please let me know if you get any issues. |
benmccann
reviewed
Jul 16, 2020
| @@ -38,6 +39,22 @@ export default class RollupResult implements CompileResult { | |||
| // webpack, but we can have a route -> [chunk] map or something | |||
| this.assets = {}; | |||
|
|
|||
| this.script_preloads = {} | |||
| const entryChunk = compiler.chunks.find(ch => ch.isEntry) | |||
| const addImportsToScripsPreload = (facadeModuleId:string, chunk:Chunk) => { | |||
|
I've sent #1269 which handles transitive JS dependencies as well as CSS files |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #440, fixes #408.
Preloading scripts content is important to supply good Google site speed rate. The #440 PR looks outdated so I implemented an own solution.