Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve component event handler type #314

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Conversation

ota-meshi
Copy link
Member

Related to sveltejs/eslint-plugin-svelte#432

This PR improves assigning the correct event handler type when the component type is available.

However, since @typescript-eslint/parser cannot be used to retrieve component types, users should use the experimental parser typescript-eslint-parser-for-extra-files instead. .
If the user is using @typescript-eslint/parser it will be the same as before.

@coveralls
Copy link

coveralls commented Apr 8, 2023

Pull Request Test Coverage Report for Build 4749304045

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 90.631%

Files with Coverage Reduction New Missed Lines %
src/parser/converts/common.ts 1 94.74%
src/parser/converts/element.ts 11 92.8%
Totals Coverage Status
Change from base Build 4643414505: -0.08%
Covered Lines: 2095
Relevant Lines: 2235

💛 - Coveralls

@ota-meshi ota-meshi merged commit 96a72a5 into main Apr 26, 2023
11 checks passed
@ota-meshi ota-meshi deleted the improve-event-type branch April 26, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants