Partial accept #58
Merged
Partial accept #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikg
reviewed
Sep 16, 2022
|
Should we enable this by default in v-p-s? |
Yes, I think so. This is arguably a bug fix. |
Merged
dominikg
approved these changes
Sep 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Vite's partial accept, to fix HMR glitches with components that use
context:module(see sveltejs/vite-plugin-svelte#134, for example).Notice that there is really only one change, in
packages/svelte-hmr/lib/make-hot.js. I should probably not have updated/added the demo apps in the same PR 馃槄 And then, there's the required configuration inplayground/vite-app/vite.config.js.To appreciate the effect, edit
ModuleContext.sveltein the Vite app, with or without the partial accept config, and observe the difference in Vite's HMR logs. With partial accept,ModuleContext.svelteandCmpUsingContext.svelteget updated (but notCmpUsingOnlyDefault.svelte) and the change of the export frommodule:contextis correctly reflected. Without partial accept, onlyModuleContext.sveltegets updated (because it eats the HMR bubble), and changing the value ofyisn't reflected correctly.