fix: adjust store regex (#441)

Don't match in the case of $° or $§ or $\, these are not store variables Fixes #433
sveltejs · Dec 16, 2021 · 85a86c8 · 85a86c8
1 parent f6ef334
commit 85a86c8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/transformers/typescript.ts b/src/transformers/typescript.ts
@@ -152,7 +152,8 @@ function injectVarsToCode({
   // TODO investigate if it's possible to achieve this with a
   // TS transformer (previous attemps have failed)
   const codestores = Array.from(
-    contentForCodestores.match(/\$[^\s();:,[\]{}.?!+-=*/~|&%<>^`"']+/g) || [],
+    contentForCodestores.match(/\$[^\s();:,[\]{}.?!+-=*/\\~|&%<>^`"'°§]+/g) ||
+      [],
     (name) => name.slice(1),
   ).filter((name) => !JAVASCRIPT_RESERVED_KEYWORD_SET.has(name));
 

diff --git a/test/fixtures/TypeScriptImports.svelte b/test/fixtures/TypeScriptImports.svelte
@@ -39,6 +39,11 @@
     }
     $storeScriptOnly;
     $storeModuleScriptOnly;
+
+    // These shouldn't count as store values:
+    // $\\; $$; $§; $%; $°; $(; $); $[; $]; $<; $>; $ ; $^; $`; $"; $';
+    // These don't need to be tested explicitly, the test will throw and error
+    // at the TypeScript parsing stage if they are part of the false positives
 </script>
 
 <style>